Skip to content

refactor(material/button): handle disabled state of icon buttons through tokens #27990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2023
Merged

refactor(material/button): handle disabled state of icon buttons through tokens #27990

merged 1 commit into from
Oct 24, 2023

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 24, 2023

  • Fixes that icon buttons weren't using the right token for disabled state.
  • Fixes that the specificity of the icon button disabled styles was really high.
  • Moves the logic for generating the palette tokens into the icon button tokens file.
  • Fixes one place where we were referencing a token directly instead of using the API to generate the name.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels Oct 24, 2023
@crisbeto
refactor(material/button): handle disabled state of icon buttons thro…
36e68e0 
…ugh tokens

* Fixes that icon buttons weren't using the right token for disabled state.
* Fixes that the specificity of the icon button disabled styles was really high.
* Moves the logic for generating the palette tokens into the icon button tokens file.
* Fixes one place where we were referencing a token directly instead of using the API to generate the name.
@crisbeto crisbeto self-assigned this Oct 24, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 24, 2023
@crisbeto crisbeto merged commit 34ec567 into angular:17.0.x Oct 24, 2023
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 24, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @wagnermaciel